Make cvxopt a required dependency, remove optional dependencies matplotlib and seaborn #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvxopt is required for titer models to work.
These plotting modules are only used in an old titer model function [1] and two test functions in the frequency estimation module [2][3]. [1]: https://github.com/nextstrain/augur/blob/efcc8be3bcf72ab4beb237afcc5b4b002bbaa806/augur/titer_model.py#L508-L509 [2]: https://github.com/nextstrain/augur/blob/24e5d2940918b10e2be39d6e7a63dcceff792860/augur/frequency_estimators.py#L748 [3]: https://github.com/nextstrain/augur/blob/24e5d2940918b10e2be39d6e7a63dcceff792860/augur/frequency_estimators.py#L782
victorlin
force-pushed
the
victorlin/update-dependencies
branch
from
a1396ef to
698c5f4
Compare
1 task
tsibley
approved these changes
Sep 6, 2022
|
Noting for posterity that anyone trying to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependency list based on discussion in #672. Closes #672.
Testing
Checklist
fulldependency list (cs.github.com query):