Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename force inclusion filtering functions #1006

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jul 20, 2022

Description of proposed changes

  • include -> force_include_strains
  • include_by_include_where -> force_include_where

I found the existing names a bit vague/confusing. These names are more descriptive in my opinion. Open to other suggestions.

Related issue(s)

N/A

Testing

  • Updated test data file
  • CI passes

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR. Keep headers and formatting consistent with the rest of the file.

- include -> force_include_strains
- include_by_include_where -> force_include_where

I found the existing names a bit vague/confusing. Replacing with more
descriptive names.
@victorlin victorlin requested a review from a team July 20, 2022 18:12
@victorlin victorlin self-assigned this Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (cea6b96) to head (73a9ae5).
Report is 1292 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   59.64%   59.64%           
=======================================
  Files          53       53           
  Lines        6317     6317           
  Branches     1586     1586           
=======================================
  Hits         3768     3768           
  Misses       2286     2286           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorlin victorlin merged commit 2e4aa88 into nextstrain:master Jul 20, 2022
@victorlin victorlin deleted the filter/rename-include-fns branch July 20, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants