Add URL encoding when revision name is used as HTTP query parameter #6598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
changed the title
pditommaso
requested changes
Nov 21, 2025
Member
pditommaso
left a comment
pditommaso
left a comment
There was a problem hiding this comment.
Good initiative, however we need to a real integration test to validate this for each modified provider (there's already a test repo for each of them)
Member
|
I've created a branch |
Signed-off-by: jorgee <[email protected]>
Signed-off-by: jorgee <[email protected]>
Member
|
@pditommaso I will leave this one to you for approval Are you comfortable with backporting it to 25.10? Seems like the fix is pretty simple and most of the PR changes are just adding tests |
Member
|
It could, let's make a round with |
Signed-off-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6441
This pull request improves the handling of branch and revision names in repository provider classes by ensuring that all revision and path parameters in URLs are properly URL-encoded. This prevents issues when branch names contain special characters. The changes are applied across Azure, Bitbucket Server, Gitea, Github, and Gitlab providers, and corresponding tests are added to verify correct behavior.
All repository provider classes (
AzureRepositoryProvider,BitbucketServerRepositoryProvider,GiteaRepositoryProvider,GithubRepositoryProvider, andGitlabRepositoryProvider) now encode revision and path parameters usingURLEncoder.encodewithStandardCharsets.UTF_8to ensure proper URL formatting and avoid errors with special characters in branch names.Additional encoding is applied in methods that resolve revisions to commit SHAs and list directory contents, ensuring consistency throughout all API requests.
New test cases are added for each provider to verify that URLs are correctly generated when branch names include special characters, such as slashes, plus signs, and ampersands.