Skip to content

Conversation

bentsherman
Copy link
Member

Close #5785

This PR fixes a false positive error with storeDir that causes it to be overly strict with value outputs.

Currently storeDir only works with value outputs of the form val(<name>), where <name> is defined as an input or in the script block. However, any value output should be allowed, because value outputs are always evaluated and do not depend on the storeDir or resume cache.

Test case:

process FOO {
    storeDir 'store'

    output:
    tuple val(task.process), val('grep'), path('version.txt')

    script:
    """
    grep --version | head -n 1 > version.txt
    """
}

workflow {
    FOO()
}

Currently, the two value outputs above will caused the task to not be stored. With this PR, the task is stored correctly.

@bentsherman bentsherman requested a review from jorgee September 16, 2025 14:39
Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 003fe31
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68ee4e5fd3febc00084cfd8a
😎 Deploy Preview https://deploy-preview-6408--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jorgee
Copy link
Contributor

jorgee commented Sep 17, 2025

It would be good to add the test case as integration test

@bentsherman
Copy link
Member Author

TODO: update dynamic-storedir.nf to include this case

Signed-off-by: Ben Sherman <[email protected]>
@bentsherman bentsherman requested review from jorgee and removed request for jorgee October 13, 2025 17:52
@bentsherman bentsherman merged commit 1aa8c44 into master Oct 14, 2025
22 checks passed
@bentsherman bentsherman deleted the fix-storedir-error branch October 14, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

topic channel output breaks storeDir

2 participants