Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kill task logic #5594

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

pditommaso
Copy link
Member

This PR improves the task kill logic as below:

  1. implement the flag check in the kill method (instead of a new one) for a) API backward compatibility, and b) make sure it's invoked by the already existing component
  2. use an AtomicBool to make the handling of a possible race condition more robust
  3. rename existing kill methods to killTask and declare protected to highlight it should not be invoked directly
  4. do not mark kill as final (even if it would be better) to prevent breaking asking plugins

Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit 2e14391 into 5516-awsbatch-error-500 Dec 10, 2024
16 checks passed
@pditommaso pditommaso deleted the 5516-awsbatch-error-v2 branch December 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants