Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the task kill logic as below:
kill
method (instead of a new one) for a) API backward compatibility, and b) make sure it's invoked by the already existing componentAtomicBool
to make the handling of a possible race condition more robustkill
methods tokillTask
and declareprotected
to highlight it should not be invoked directlykill
asfinal
(even if it would be better) to prevent breaking asking plugins