More robust parsing of shm-size containerOptions #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
robsyme
force-pushed
the
shm-testing
branch
2 times, most recently
from
aebffa7 to
b8fa1ad
Compare
This commit ensures that the `shm-size` option is correctly parsed from the containerOptions. This is necessary to ensure that the correct value in MiB is passed to the AWS Batch API when creating a job definition. Signed-off-by: Rob Syme <[email protected]>
Signed-off-by: Rob Syme <[email protected]>
|
This does adjust an existing test, but I'd argue that the original test was incorrect, given that AWS measure shared memory in MiB and not in bytes (see sharedMemorySize docs). |
robsyme
commented
Jul 26, 2024
plugins/nf-amazon/src/test/nextflow/cloud/aws/batch/AwsContainerOptionsMapperTest.groovy
Show resolved
Hide resolved
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
added a commit
that referenced
this pull request
Aug 1, 2024
This commit ensures that the `shm-size` option is correctly parsed from the containerOptions. This is necessary to ensure that the correct value in MiB is passed to the AWS Batch API when creating a job definition. Signed-off-by: Rob Syme <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
|
Concerning forum post that could indicate a problem with this PR: https://community.seqera.io/t/shared-memory-bug/1090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the
shm-sizeoption is correctly parsed from the containerOptions. This is necessary to ensure that the correct value in MiB is passed to the AWS Batch API when creating a job definition.Fixes #5176