-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Google Batch 5000x error class handling #5141
Conversation
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
See also: nextflow/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy Lines 262 to 277 in cb63ec9
|
Just a user opinion, I would prefer these errors not to change the task attempt number, as in a dynamic configurations this would lead to unnecessary increase of resources, or unnecessary termination/ignoration of the process. |
This change makes it possible to recover errors from 50002 to 50006, similarly to 50001. Currently, they are causing the termination of the pipeline execution. @bentsherman Regarding the Batch automatic recovery, I didn't change it on purpose because the semantic settings are specific for spot interruption since it's named The this failures can be recovered with the usual error strategy. |
From meeting discussion, we suggested using a new config setting e.g. |
Merging this. I'll open a separate PR for the retry logic at this comment |
This PR improve the handling of Google Batch 5000x error class in such a way that
ProcessException
including the source error descriptionerrorRetry
strategies can be applied to handle the error condition