Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds example of error strategies to documentation #5121

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Jul 8, 2024

Should improve clarity around the role of workflow.failOnIgnore with the different errorStrategies

Should improve clarity around the role of `workflow.failOnIgnore` with the different errorStrategies

Signed-off-by: Adam Talbot <[email protected]>
@adamrtalbot adamrtalbot requested a review from a team as a code owner July 8, 2024 10:44
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit a93cf99
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/668bc46cb5a4690008d5f32f
😎 Deploy Preview https://deploy-preview-5121--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Adam Talbot <[email protected]>
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@pditommaso pditommaso merged commit e82b0de into nextflow-io:master Jul 8, 2024
11 checks passed
Copy link
Contributor

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer to me 👍

I would suggest to link to the corresponding workflow.failOnIgnore entry on the metadata.md page (? I think it was there) for completeness, otherwise I would be happy with this.

@ewels
Copy link
Member

ewels commented Jul 8, 2024

Agree that linking between the two parts of the docs would help 👍🏻

Fancy opening a PR @jfy133 ? 😆

@jfy133
Copy link
Contributor

jfy133 commented Jul 8, 2024

#5122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants