Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom fuse device plugin #4612

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Conversation

pditommaso
Copy link
Member

@pditommaso pditommaso commented Dec 21, 2023

When Nextflow uses Fusion over K8s with unprivileged mode requires the use of the k8s-fuse-plugin to mount the FUSE device.

Other plugins are available which requires the use of a custom fuse device name to be specified in the K8s spec.

This PR adds the ability to specify a custom fuse device name via the nextflow config file. For example:

k8s {
   fuseDevicePlugin = ['smarter-devices/fuse':1] 
}

Solved #4611

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 1c9c916
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/65ac0b7a4dbed700083f5e2f
😎 Deploy Preview https://deploy-preview-4612--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pditommaso pditommaso marked this pull request as draft December 21, 2023 21:10
@ehfd
Copy link

ehfd commented Dec 21, 2023

Wow, this is less than half an hour, wonderful!

@pditommaso
Copy link
Member Author

Copy link
Member

@bentsherman bentsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to document the new option

@pditommaso pditommaso marked this pull request as ready for review January 20, 2024 17:16
Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit a1e3319 into master Jan 20, 2024
10 of 22 checks passed
@pditommaso pditommaso deleted the k8s-custom-fuse-device branch January 20, 2024 18:17
nschan pushed a commit to nschan/nextflow that referenced this pull request Feb 6, 2024
This commit allows customising the FUSE plugin device required
by Fusion when using the Kubernetes executor. The FUSE plugin
name  can be specified by using the setting `k8s.fuseDevicePlugin`
for example:

```
k8s.fuseDevicePlugin = ['my-plugin/fuse': 1]
```

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Niklas Schandry <[email protected]>
nschan pushed a commit to nschan/nextflow that referenced this pull request Feb 6, 2024
This commit allows customising the FUSE plugin device required
by Fusion when using the Kubernetes executor. The FUSE plugin
name  can be specified by using the setting `k8s.fuseDevicePlugin`
for example:

```
k8s.fuseDevicePlugin = ['my-plugin/fuse': 1]
```

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Niklas Schandry <[email protected]>
nschan pushed a commit to nschan/nextflow that referenced this pull request Feb 6, 2024
This commit allows customising the FUSE plugin device required
by Fusion when using the Kubernetes executor. The FUSE plugin
name  can be specified by using the setting `k8s.fuseDevicePlugin`
for example:

```
k8s.fuseDevicePlugin = ['my-plugin/fuse': 1]
```

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Niklas Schandry <[email protected]>
nschan pushed a commit to nschan/nextflow that referenced this pull request Feb 12, 2024
This commit allows customising the FUSE plugin device required
by Fusion when using the Kubernetes executor. The FUSE plugin
name  can be specified by using the setting `k8s.fuseDevicePlugin`
for example:

```
k8s.fuseDevicePlugin = ['my-plugin/fuse': 1]
```

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Niklas Schandry <[email protected]>
nschan pushed a commit to nschan/nextflow that referenced this pull request Feb 12, 2024
This commit allows customising the FUSE plugin device required
by Fusion when using the Kubernetes executor. The FUSE plugin
name  can be specified by using the setting `k8s.fuseDevicePlugin`
for example:

```
k8s.fuseDevicePlugin = ['my-plugin/fuse': 1]
```

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Niklas Schandry <[email protected]>
nschan pushed a commit to nschan/nextflow that referenced this pull request Apr 3, 2024
This commit allows customising the FUSE plugin device required
by Fusion when using the Kubernetes executor. The FUSE plugin
name  can be specified by using the setting `k8s.fuseDevicePlugin`
for example:

```
k8s.fuseDevicePlugin = ['my-plugin/fuse': 1]
```

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Niklas Schandry <[email protected]>
nschan pushed a commit to nschan/nextflow that referenced this pull request Apr 3, 2024
This commit allows customising the FUSE plugin device required
by Fusion when using the Kubernetes executor. The FUSE plugin
name  can be specified by using the setting `k8s.fuseDevicePlugin`
for example:

```
k8s.fuseDevicePlugin = ['my-plugin/fuse': 1]
```

Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Niklas Schandry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying plugins to supply the FUSE device for the Fusion file system
3 participants