Fix errors when NXF_HOME contains spaces #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
See also, the original issue provides a test script to reproduce the error and confirm that this PR fixes it. |
pditommaso
reviewed
Oct 30, 2023
pditommaso
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4360
This PR applies the changes suggested in the original issue, basically ensures that any variables based on
NXF_HOMEare correctly quoted to prevent argument splitting.Note the caveat from the original issue:
I do not have more bash-fu, so I did not try to find a better solution...
By the way, a helpful thing I found was to install the shellcheck extension in VS Code (should be an equivalent in IntelliJ) which provides lots of hints for these problems.