Skip to content

Conversation

@adamchalmers
Copy link
Contributor

@adamchalmers adamchalmers commented Oct 31, 2025

This enables the new in-terminal progress bar (which uses OSC 9;4) if nextest is running inside the Ghostty terminal.

See #2715

Here's a video of it working, with my local nextest build.

Nextest.with.progress.bar.mp4

It also does a tiny incidental refactor, making the other terminal-specific checks use var_os instead of var to use fewer allocations.

This enables the new in-terminal progress bar (which uses OSC 9;4)
if nextest is running inside the Ghostty terminal.

See nextest-rs#2715
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.89%. Comparing base (36843fd) to head (e971c43).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nextest-runner/src/reporter/displayer/progress.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2724      +/-   ##
==========================================
- Coverage   77.91%   77.89%   -0.02%     
==========================================
  Files         112      112              
  Lines       25692    25696       +4     
==========================================
- Hits        20017    20016       -1     
- Misses       5675     5680       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@RGBCube RGBCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome :) though it would be really nice if there was an universally established protocol to query supported emulator features, too late for that :(

@adamchalmers adamchalmers force-pushed the achalmers/ghostty-progress branch from 625e074 to e971c43 Compare October 31, 2025 17:46
@sunshowers
Copy link
Member

Thanks!

@sunshowers sunshowers merged commit c70f4f6 into nextest-rs:main Oct 31, 2025
23 checks passed
case added a commit to case/nextest that referenced this pull request Jan 13, 2026
@case case mentioned this pull request Jan 13, 2026
sunshowers pushed a commit that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants