Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent CannotSendMessages or CannotEmbedLinks on interaction #45

Merged
merged 2 commits into from
Jul 30, 2022
Merged

fix: Prevent CannotSendMessages or CannotEmbedLinks on interaction #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685f916
fix: Don't show CannotSendMessages if not using ctx
DenverCoder1 Jul 29, 2022
c413533
fix: don't raise CannotEmbedLinks on interaction
DenverCoder1 Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions nextcord/ext/menus/menus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,12 +469,13 @@ def _verify_permissions(
permissions: Permissions,
):
is_thread = isinstance(channel, nextcord.Thread)
if is_thread and not permissions.send_messages_in_threads:
raise CannotSendMessages()
elif not is_thread and not permissions.send_messages:
if ctx is not None and (
(is_thread and not permissions.send_messages_in_threads)
or (not is_thread and not permissions.send_messages)
):
raise CannotSendMessages()

if self.check_embeds and not permissions.embed_links:
if ctx is not None and self.check_embeds and not permissions.embed_links:
raise CannotEmbedLinks()

self._can_remove_reactions = permissions.manage_messages
Expand Down