Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permissions checks for threads #34

Merged
merged 1 commit into from
Feb 24, 2022
Merged

fix: permissions checks for threads #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions examples/embed_pages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ async def format_page(self, menu, entries):
embed = Embed(title="Entries")
for entry in entries:
embed.add_field(name=entry[0], value=entry[1], inline=True)
embed.set_footer(text=f'Page {menu.current_page + 1}/{self.get_max_pages()}')
embed.set_footer(text=f"Page {menu.current_page + 1}/{self.get_max_pages()}")
return embed


@bot.command()
async def button_embed_field(ctx):
data = [
Expand Down Expand Up @@ -66,18 +67,18 @@ def __init__(self, data):

async def format_page(self, menu, entries):
embed = Embed(title="Entries", description="\n".join(entries))
embed.set_footer(text=f'Page {menu.current_page + 1}/{self.get_max_pages()}')
embed.set_footer(text=f"Page {menu.current_page + 1}/{self.get_max_pages()}")
return embed


@bot.command()
async def button_embed_description(ctx):
data = [f'Description for entry #{num}' for num in range(1, 51)]
data = [f"Description for entry #{num}" for num in range(1, 51)]
pages = menus.ButtonMenuPages(
source=MyEmbedDescriptionPageSource(data),
clear_buttons_after=True,
)
await pages.start(ctx)


bot.run('token')
bot.run("token")
5 changes: 4 additions & 1 deletion nextcord/ext/menus/menus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,10 @@ def _verify_permissions(
channel: nextcord.abc.Messageable,
permissions: Permissions,
):
if not permissions.send_messages:
is_thread = isinstance(channel, nextcord.Thread)
if is_thread and not permissions.send_messages_in_threads:
raise CannotSendMessages()
elif not is_thread and not permissions.send_messages:
raise CannotSendMessages()

if self.check_embeds and not permissions.embed_links:
Expand Down