fix: should_add_reactions returning true for Button menu #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenverCoder1
changed the title
ooliver1
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
should_add_reactionsis returning true forMenuPageswhen there are no reactions. This makes it check for reactions permissions when it does not need to.Solution:
MenuPages.should_add_reactions_or_buttons()now uses the implementation ofMenuby returningself.should_add_reactions() or self.should_add_buttons().MenuPages.should_add_reactions()andMenuPages.should_add_buttons()now call their respective super() implementations in addition to checking if paginating.ButtonMenuPages,should_add_buttons()is overridden to only check if the source is paginating since buttons are added in the constructor andshould_add_buttons()is checked in the constructor before the buttons are added.