Video player bugfixes #799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in full screen mode Fixed bug when video not loading and error was shown if filename or directory name contains special symbols, like & Signed-off-by: anton.z <[email protected]>
|
Hi, sorry, the fullscreen fix is not acceptable as we need to keep the video sizing on load. Regarding the second fix, please open a dedicated pr for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix two errors in plyr video player.
1 bug is if I going to full screen mode, the video is not stretched to the full screen.
2 bug is an error shown instead of video if file name or directory name contains special symbols, like &. This bug was only on public shared folders and described in detail here