Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing while slideshow in full screen mode #2380

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sanskar-soni-9
Copy link
Contributor

Fix #2379

@sanskar-soni-9 sanskar-soni-9 self-assigned this Jul 29, 2024
@sanskar-soni-9 sanskar-soni-9 added the 3. to review Waiting for reviews label Jul 29, 2024
@sanskar-soni-9 sanskar-soni-9 requested a review from skjnldsv July 29, 2024 07:22
@skjnldsv

This comment was marked as resolved.

@sanskar-soni-9

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@sanskar-soni-9

This comment was marked as resolved.

@sanskar-soni-9 sanskar-soni-9 force-pushed the fix/editing-while-slideshow-in-full-screen branch from 9077f8b to d315aac Compare July 30, 2024 07:36
@skjnldsv
Copy link
Member

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jul 30, 2024
@skjnldsv
Copy link
Member

/backport to stable28

@skjnldsv skjnldsv added bug Something isn't working 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 30, 2024
@skjnldsv skjnldsv merged commit 778decc into master Jul 30, 2024
30 of 31 checks passed
@skjnldsv skjnldsv deleted the fix/editing-while-slideshow-in-full-screen branch July 30, 2024 09:55
Copy link

backportbot bot commented Jul 30, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2380/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d315aac7

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2380/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Jul 30, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slideshow continues to slide files while editing
2 participants