Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): Adjust testing matrix for Nextcloud 30 on main #752

Closed
wants to merge 1 commit into from
Closed

chore(CI): Adjust testing matrix for Nextcloud 30 on main #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
node-version: [20]
php-versions: ['8.1']
databases: ['sqlite']
server-versions: ['stable28', 'master']
server-versions: ['stable28', 'stable29', 'stable30', 'master']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I think it's a bit waste of CI minutes to run Cypress against each supported server branch. Running it against the lowest supported and master so far worked well for me in other apps. What do you think @nickvergessen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we end up here every time :D
Fine by me, just adjust it and merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to change anything then 🎉


steps:
- name: Set app env
Expand Down
Loading