Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/search highlight improvements #6052

Merged
merged 12 commits into from
Jul 23, 2024
Merged

Feat/search highlight improvements #6052

merged 12 commits into from
Jul 23, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jul 15, 2024 •
edited

📝 Summary

This pull request includes fixes which improve the search highlighting for integration with other apps, namely with Collectives but also provides a proper foundation for integrating it within other apps.

🚧 TODO

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@elzody elzody self-assigned this Jul 15, 2024
@elzody
fix: Begin adding ability to specify match index to highlight
2a30da6 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
feat: Navigate to next match
3bd7227 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix(tests): Fix tests for new implementation
b458e4b 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
feat(tests): Add test for next match
07e8746 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Normalize search index to properly navigate to prev/next match
aa92677 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Return proper number of search matches
c6ec9fa 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Re-run if matchAll changed
a72b51e 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Return index from search
58c596d 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix(test): Update test case
76b95b1 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody elzody added this to the Nextcloud 30 milestone Jul 23, 2024
@elzody elzody marked this pull request as ready for review July 23, 2024 16:06
@elzody elzody requested a review from juliushaertl July 23, 2024 16:28
@elzody elzody merged commit 0a90c4f into main Jul 23, 2024
58 of 61 checks passed
@elzody elzody deleted the feat/search-highlight-improvements branch July 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@elzody elzody

Labels
3. to review enhancement New feature or request javascript 🍂 2024-Autumn
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Search highlight
2 participants
@elzody @AndyScherzinger