Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force visibility for tippy #5537

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix: Force visibility for tippy #5537

merged 1 commit into from
Mar 20, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 20, 2024

This seems to have changed with viewer changing from @nextcloud/vue from 8.4.0 to 8.8.1 but I could not figure out the difference there, however this brings back the assistant button (consider it a hotfix)

Also noted as a workaround in ueberdosis/tiptap#4851

Fix #5448

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr added bug Something isn't working 3. to review high labels Mar 20, 2024
@juliusknorr juliusknorr self-assigned this Mar 20, 2024
@juliusknorr juliusknorr added this to the Nextcloud 29 milestone Mar 20, 2024
@juliusknorr
Copy link
Member Author

php lint failure is unrelated (CI issue)

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that looks violent, but if it works 🙈

@juliusknorr
Copy link
Member Author

Yeah spent too much hours already into that, so hopefully can figure out the root cause when things are a bit more quiet

@juliusknorr juliusknorr merged commit aa3e6a5 into main Mar 20, 2024
55 of 59 checks passed
@juliusknorr juliusknorr deleted the fix/assistant-preview branch March 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working high
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Assistant button is currently broken
2 participants