Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not register text/csv mimetype when office can handle it #2448

Merged
merged 1 commit into from
May 25, 2022

Conversation

juliusknorr
Copy link
Member

Make sure to only register CSV handling for the viewer when there are no other options as Collabora and ONLYOFFICE have better capabilities for showing and editing those.

We could have this as an optional file opener through the 3 dots menu, but the viewer currently does not support that and only allows registering for the default file action.

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels May 25, 2022
@juliusknorr juliusknorr added this to the Nextcloud 25 milestone May 25, 2022
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for tackling this.

@juliusknorr
Copy link
Member Author

/compile amend /

Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit 0d54c3a into master May 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/csv branch May 25, 2022 19:46
@juliusknorr
Copy link
Member Author

/backport to stable24

@juliusknorr
Copy link
Member Author

/backport to stable23

@juliusknorr
Copy link
Member Author

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants