Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve save terms and reset signaturies actions #1019

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

GretaD
Copy link
Collaborator

@GretaD GretaD commented Nov 27, 2024

fixes: https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1037

This update clarifies the purpose of the buttons, ensuring admins understand when to save changes and when to send notifications to users.

before
Screenshot from 2024-11-27 11-47-36

after
Screenshot from 2024-11-27 12-27-12

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great, thanks! :)

src/App.vue Outdated Show resolved Hide resolved
@GretaD GretaD force-pushed the add/reset-signatories branch from e709836 to e57482e Compare November 27, 2024 11:24
@GretaD GretaD requested a review from nickvergessen November 27, 2024 11:24
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to commit compiled code I think

src/App.vue Show resolved Hide resolved
src/App.vue Show resolved Hide resolved
@GretaD GretaD force-pushed the add/reset-signatories branch from e57482e to 26181ee Compare November 27, 2024 11:31
@GretaD
Copy link
Collaborator Author

GretaD commented Nov 27, 2024

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@GretaD GretaD requested a review from nickvergessen November 27, 2024 11:39
@nickvergessen nickvergessen merged commit b30538d into master Nov 27, 2024
29 checks passed
@nickvergessen nickvergessen deleted the add/reset-signatories branch November 27, 2024 11:43
@GretaD
Copy link
Collaborator Author

GretaD commented Dec 12, 2024

/backport to stable27

Copy link

backportbot bot commented Dec 12, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/1019/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 26181ee0 8cce71d8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1019/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@max-nextcloud
Copy link
Collaborator

/backport 26181ee to stable27

Copy link

backportbot bot commented Dec 12, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/1019/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 26181ee0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1019/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants