Migrate from NcMultiselect to NcSelect #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 28.71% 28.65% -0.07%
Complexity 39 39
============================================
Files 69 69
Lines 3026 3033 +7
Branches 733 733
============================================
Hits 869 869
- Misses 2157 2164 +7 |
raimund-schluessler
force-pushed
the
fix/noid/nc-select
branch
from
8eba229 to
e2985af
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/nc-select
branch
from
e2985af to
452c6e0
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/nc-select
branch
from
22d8f6d to
1530b1f
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/nc-select
branch
from
1530b1f to
1e047bd
Compare
raimund-schluessler
added
design
3 - to review
dependencies
This was referenced Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the select dropdowns from
NcMultiselecttoNcSelect.