Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): handle opening new installation instance #859

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 30, 2024

☑️ Resolves

  • Allows launching a new instance of Talk instead of a running one
  • Prevents a situation when there is an old Talk keep running in the background instead of a new one after installation

How to test

  1. Build executable with npm run build
  2. Copy it to a new location. now you have 2 "installations"
  3. Run the first one, open some chat/settings
  4. Minimize or close the window
  5. Try to run the first installation again
    • It should open/focus the window
  6. Open the second installation
    • Before: the first window is open instead of the new installation
    • After: the first installation is closed and the new is launched
  7. Run the second installation again
    • Just to make sure it still works as expected for a single instance

@ShGKme ShGKme added bug Something isn't working 3. to review labels Oct 30, 2024
@ShGKme ShGKme requested a review from nickvergessen October 30, 2024 22:30
@ShGKme ShGKme self-assigned this Oct 30, 2024
@ShGKme ShGKme mentioned this pull request Nov 8, 2024
@Antreesy
Copy link
Contributor

Antreesy commented Nov 8, 2024

  1. Build executable with npm run build
  2. Copy it to a new location. now you have 2 "installations"

That's why it doesn't work with old builds 👀

@ShGKme ShGKme force-pushed the fix/run-second-installation branch from f2e0357 to 6f33251 Compare November 8, 2024 16:20
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 8, 2024

Rebased onto main

@ShGKme ShGKme enabled auto-merge November 8, 2024 16:20
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 8, 2024

That's why it doesn't work with old builds 👀

Not sure what you mean

@ShGKme ShGKme merged commit dbdaa31 into main Nov 8, 2024
10 checks passed
@ShGKme ShGKme deleted the fix/run-second-installation branch November 8, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants