Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: specify built-in Talk version in package.json #858

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 29, 2024

☑️ Resolves

Allows to:

  • Have the built-in Talk version in the repository history
  • Have a PR to explicitly bump the built-in Talk version
  • Reproduce a release package with a simple git checkout version + release:package instead of searching in the changelog for the Talk version
  • Build release on CI. Before, a Talk version was manually specified by a developer during the release

Currently, it only affects the release:package script used in the releases.

Follow-ups:

  • Use it for repo init instead of git clone spreed
  • Automate built-in Talk version bump

@ShGKme ShGKme added 2. developing technical debt Maintenance and refactoring labels Oct 29, 2024
@ShGKme ShGKme self-assigned this Oct 29, 2024
@ShGKme ShGKme force-pushed the build/fix-built-in-talk-version branch 2 times, most recently from 3a2591b to e05b299 Compare October 30, 2024 16:50
@ShGKme ShGKme marked this pull request as ready for review October 30, 2024 16:58
@ShGKme ShGKme force-pushed the build/fix-built-in-talk-version branch from e05b299 to dec8a2e Compare October 30, 2024 16:59
@ShGKme ShGKme changed the title build: specify built-in Talk version for release in source build: specify built-in Talk version in package.json Oct 30, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you're fine with talk.stable naming in package.json

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 31, 2024

if you're fine with talk.stable naming in package.json

Any preferences? :)

@Antreesy
Copy link
Contributor

Any preferences? :)

builtInVersion or coreAppVersion maybe?

@ShGKme ShGKme force-pushed the build/fix-built-in-talk-version branch from dec8a2e to bafd023 Compare October 31, 2024 18:00
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 31, 2024

Rebased to resolve conflict

@nickvergessen
Copy link
Member

builtInVersion or coreAppVersion maybe?

Or branch or ...

But yeah stable sounds weird, especially when it's unstable while we build with 21.0.0-betas in the future and things a like?

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 1, 2024

Or branch

But 20.0.1 is not a branch...

when it's unstable while we build with 21.0.0-betas

Then it is in beta/rc instead of stable

@ShGKme ShGKme force-pushed the build/fix-built-in-talk-version branch from bafd023 to 26a953b Compare November 8, 2024 15:15
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 8, 2024

Rebased onto main. Keeping the current simple name. It's simple to change it without any breaking changes.

Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme enabled auto-merge November 8, 2024 15:17
@ShGKme ShGKme merged commit 1514690 into main Nov 8, 2024
10 checks passed
@ShGKme ShGKme deleted the build/fix-built-in-talk-version branch November 8, 2024 15:18
@ShGKme ShGKme mentioned this pull request Nov 8, 2024
@ShGKme ShGKme mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review technical debt Maintenance and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants