Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add macOS dmg distributive #844

Merged
merged 2 commits into from
Nov 7, 2024
Merged

build: add macOS dmg distributive #844

merged 2 commits into from
Nov 7, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 24, 2024 •
edited
Loading

☑️ Resolves

Make .dmg distributive:

  • Simple to use for end-users, just drag and drop
  • No admin right required
  • Alternative - .pkg, a classic installer

🖼️ Screenshots

image

image

image

@ShGKme ShGKme self-assigned this Oct 24, 2024
@ShGKme ShGKme changed the title Build/mac dmg build: add macOS dmg distributive Oct 29, 2024
@ShGKme ShGKme marked this pull request as ready for review November 5, 2024 11:45
@ShGKme ShGKme mentioned this pull request Nov 5, 2024
Merged
Antreesy
Antreesy approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 6, 2024

Added attribution for an images based on another image. See:

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 6, 2024 •
edited
Loading

Changed category from "Social Networking" to "Business" aligned with category change for the Nextcloud Talk mobile client on iOS

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 7, 2024

Changed bundleId from com.nextcloud.NextcloudTalk to com.nextcloud.talk.mac following Talk iOS.

ShGKme added 2 commits November 7, 2024 15:03
@ShGKme
chore(devDeps): add @electron-forge/maker-dmg
58e3d0f 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
build: add macOS dmg
b2f4d0c 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 7, 2024

Considering 👍 as approve. Rebased, squashed, merging.

@ShGKme ShGKme merged commit ce3a283 into main Nov 7, 2024
10 checks passed
@ShGKme ShGKme deleted the build/mac-dmg branch November 7, 2024 14:06
@ShGKme ShGKme mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DMG as a primary macOS distributive
2 participants
@ShGKme @Antreesy