✍️ Typing indicators #3029
Merged
✍️ Typing indicators #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-17.0 |
mahibi
force-pushed
the
feature/2930/typingIndicators
branch
from
5473eba to
028b19d
Compare
mahibi
added
3. to review
|
Fine codewise besides the code checks detections |
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Without this refreshing of capabilites, depending settings (for now read privacy) were never updated until app was started again because the user still contained old capabilities. This fix will also be necessary for the typing indicator setting. Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
no need to define it redundant... Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
..."Resource IDs will be non-final by default in Android Gradle Plugin version 8.0, avoid using them as annotation attributes" by using @KeyByString keys were also wrong by copy&paste and are now fixed Signed-off-by: Marcel Hibbe <[email protected]>
-> align Unread messages above typing_indicator_wrapper Signed-off-by: Marcel Hibbe <[email protected]>
Overdraw is expected here to avoid transparency for the typing indicator view. Instead chat message content should be hidden behind the typing indicator view. Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
feature/2930/typingIndicators
branch
from
45e0bbd to
0f58dea
Compare
Signed-off-by: Marcel Hibbe <[email protected]>
followup to 0f58dea Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
otherwise chat content was visible in between Signed-off-by: Marcel Hibbe <[email protected]>
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. Signed-off-by: Marcel Hibbe <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3029-talk.apk |
|
🎉 gj! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2930
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x