Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close sidebar on mobile resolution immediately after changing the route #9762

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 12, 2023

☑️ Resolves

  • Follow up for fix closing the left sidebar on click automatically #9508
  • Previously we're waiting for server response to emit the event, that toggle sidebar. Now we do it after changing the route
    • Emitting the event comes from participantsStore async action joinConversation, which is called only on switching the conversations
    • Action is also called on App.vue beforeMount(), but sidebar toggling is also handling by App itself

🖼️ Screenshots

🏚️ Before

route-slow.mp4

🏡 After

route-fast.mp4

🚧 Tasks

  • Visual check
  • Code review
  • Testing for all 'joined-conversation' emit cases

🏁 Checklist

@Antreesy
Copy link
Contributor Author

/backport to stable27

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thanks for fixing this! :)

@szaimen
Copy link
Contributor

szaimen commented Jun 12, 2023

/backport to stable26

@Antreesy Antreesy enabled auto-merge June 12, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants