-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust typing indicator behaviour #9689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks gokd from the screenshot but didnt review the code and didnt test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested yet and haven't checked changes in webrtc
and tests but there are some blocking comments.
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
cfa26e8
to
70d732c
Compare
…ests Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
…typing Signed-off-by: Maksim Sukharev <[email protected]>
70d732c
to
32003ea
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works as described.
Personally it feels a bit long until the indicator disappears, because when you type 2 characters, we are always sending the second "startedTyping" after 10 seconds.
Signed-off-by: Maksim Sukharev <[email protected]>
Yes, but this respects #9624 |
99a3ad2
to
ff098a6
Compare
For the record: my force push was with dummy commit and its drop. GitHub had weird behavior, the new Maksim's commits appeared in the branch but not in the PR o_O |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great work!
I checked the behavior: Recording.2023-06-07.223802.mp4 |
I think, users usually type for a longer time, so 10-25s doesn't usually looks as long as in this video. Thought, it would be good if we have some way to change those values: #9717 Adding a small delay may also help with the situation on the video, then a user suddenly typed some symbols for a second: #9718 |
What about the typing indicator when the user is deleting the text, is it considered accurate? |
Yes, erasing a text is also considered as typing |
/backport to stable27 |
☑️ Resolves
After the first key stroke, we send first
true
signal start to watching after input value, if it was changed within intervals:true
signal;true
signal;In that case, first possible
true
signal will be received in 0s + delay after actor started typing;consequent signals will come every 10s + delay.
false
signal will be received:false
signal will be set locally by client:As typing person
As receiver
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required