fix(CallView): fix no local video on empty call in not grid mode #9581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
|
/backport to stable27 |
ShGKme
added
4. to release
feature: frontend 🖌️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
Since #9336 entire
#videoblock was shown only, when it is not the firstEmptyCallView. It worked for grid mode with its ownEmptyCallView, but didn't work with not grid mode. All things from not-grid mode were lost (local view (stripe), local screen-sharing, reactions).This PR fixes the conditions chain in the CallView.
P.S. diff in GitHub looks a bit strange. I removed
v-elsefrom#videoblock and wrapped everything afterViewerOverlayCallViewin<template v-else>. No changes in props.🏁 Checklist
docs/has been updated or is not required