Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Avatar editor to new conversation dialog #9465

Merged
merged 7 commits into from
May 8, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented May 5, 2023

☑️ Resolves

  • Adds avatar and description editors on conversation create dialog
  • Change styles and elements position for avatar editor
  • Change "profile picture" to "conversation picture"
  • Minor refactoring and fixes

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image
image image

🚧 Tasks

  • Visual check
  • Code review

🏁 Checklist

@nickvergessen
Copy link
Member

I love it!

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
Copy link
Contributor Author

Antreesy commented May 5, 2023

@ShGKme FYI: https://github.com/eddyerburgh/jest-transform-stub

Jest doesn't apply transforms to node_modules by default. I guess, the same rules are for jest-transform-stub
I've restored a deleted line in moduleNameMapper

@Antreesy Antreesy changed the title Feat/noid/new conversation dialog rework Add Avatar editor to new conversation dialog May 5, 2023
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

Might be good to give the 2 toggles a header too, like "Privacy" or "Conversation visibility". Cause currently they are very close under the picture. But not a blocker.

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
Copy link
Contributor Author

Antreesy commented May 8, 2023

Add a label for toggles. Input was moved to save some vertical space:

Private Public
image image

@Antreesy Antreesy enabled auto-merge May 8, 2023 14:21
@Antreesy Antreesy merged commit 1474dfc into master May 8, 2023
@Antreesy Antreesy deleted the feat/noid/new-conversation-dialog-rework branch May 8, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants