Video background image round one #9276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
force-pushed
the
feature/9269/video-background-part-1
branch
from
e15fe82 to
d383d9a
Compare
marcoambrosini
changed the title
marcoambrosini
force-pushed
the
feature/9269/video-background-part-1
branch
2 times, most recently
from
d441be8 to
f94410e
Compare
Antreesy
reviewed
Apr 14, 2023
| @@ -323,8 +310,12 @@ export default { | |||
| return !(this.hasCall && !this.isInLobby) | |||
| }, | |||
|
|
|||
| canRecordingTakePlace() { | |||
| return getCapabilities()?.spreed?.config?.call?.recording || false | |||
| showDeviceSelection() { | |||
There was a problem hiding this comment.
Please check this computed property. It's used wrong at method closeModal()
There was a problem hiding this comment.
Could you please clarify this one?
6 tasks
Merged
5 tasks
ShGKme
reviewed
Apr 14, 2023
This comment was marked as outdated.
This comment was marked as outdated.
marcoambrosini
force-pushed
the
feature/9269/video-background-part-1
branch
from
f94410e to
4f31a61
Compare
marcoambrosini
force-pushed
the
feature/9269/video-background-part-1
branch
2 times, most recently
from
536ce23 to
c52c195
Compare
nickvergessen
requested changes
Apr 17, 2023
nickvergessen
requested changes
Apr 17, 2023
marcoambrosini
force-pushed
the
feature/9269/video-background-part-1
branch
2 times, most recently
from
50ef3b6 to
85447d5
Compare
marcoambrosini
added
3. to review
enhancement
feature: frontend 🖌️
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco <[email protected]>
marcoambrosini
force-pushed
the
feature/9269/video-background-part-1
branch
from
63477f0 to
3e9dbbe
Compare
nickvergessen
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏚️ Before | 🏡 After
🚧 Tasks
DeviceCheckerintoMediaSettingsMediaSettingsfrom call viewMediaSettingslayoutvideoBackgroundEditorcomponentvideoBackgroundEditorvideoBackgroundEditor🏁 Checklist
docs/has been updated or is not required