Move signaling to vue buttons #7647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
bug
feature: settings ⚙️
nickvergessen
force-pushed
the
bugfix/noid/move-signaling-to-vue-buttons
branch
from
d9d1157 to
9bef084
Compare
Member
Author
|
Removed the checkbox change (is now tracked in #7707 ) so all buttons are done with this PR |
3 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/move-signaling-to-vue-buttons
branch
from
9bef084 to
a829ecb
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
raimund-schluessler
approved these changes
Aug 11, 2022
Member
raimund-schluessler
left a comment
raimund-schluessler
left a comment
There was a problem hiding this comment.
Code looks good, I didn't test it though.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.