-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start with integration tests for invites #6427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Oct 28, 2021
•
edited
Loading
edited
- Test that it doesn't work when federation is not enabled
- Test remote participant is added to participant list
- Test invite is sent
- Test accepting an invite (any change for the inviter?)
- Test declining an invite (is the remote participant removed?)
- Test requesting the room as a remote participant
- Test if remote participants can see the participant list
nickvergessen
added
2. developing
bug
feature: api 🛠️
OCS API for conversations, chats and participants
feature: federation 🌐
labels
Oct 28, 2021
nickvergessen
commented
Oct 28, 2021
nickvergessen
force-pushed
the
integration-tests-for-invites
branch
from
October 29, 2021 08:08
bc421c8
to
72831d8
Compare
Next step
|
|
This is just proving the usefulness of tests, isn't it. I will get started on the messaging sharing after this is done. |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
integration-tests-for-invites
branch
from
November 3, 2021 13:47
499c834
to
c68c15b
Compare
Not there yet, but let's merge this in between step as it fixes some issues and brings us closer without having merge conflicts at the end |
Open tasks where moved to #5723 |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
integration-tests-for-invites
branch
from
November 3, 2021 13:53
c68c15b
to
93a080c
Compare
Signed-off-by: Joas Schilling <[email protected]>
vitormattos
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
bug
feature: api 🛠️
OCS API for conversations, chats and participants
feature: federation 🌐
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.