Select media device for video and audio input #1450
Conversation
|
Please rebase the merge request and remove unrelated commits from #1422 from this branch. |
… source and audio output device. Signed-off-by: Peter Edens <[email protected]>
Signed-off-by: Peter Edens <[email protected]>
Peterede
force-pushed
the
select_media_device
branch
from
5a3236e to
c05c791
Compare
Signed-off-by: Peter Edens <[email protected]>
|
rebased and removed unrelated commits |
| @@ -91,6 +111,7 @@ | |||
| canFullModerate: this._canFullModerate(), | |||
| isPublic: this.model.get('type') === 3, | |||
| showShareLink: !canModerate && this.model.get('type') === 3, | |||
| canPublish: OCA.SpreedMe.canPublish(), | |||
There was a problem hiding this comment.
TypeError: OCA.SpreedMe.canPublish is not a function
There was a problem hiding this comment.
This is from another pull request #1298
| OCA.SpreedMe.webrtc.startLocalVideo(OCA.SpreedMe.webrtc.config.media); | ||
| OCA.SpreedMe.app.connection.joinCall(this.activeRoom.get('token')); | ||
|
|
||
| /*var senders = existingPeer.pc.getLocalStreams(); |
There was a problem hiding this comment.
If the code is not needed remove it.
|
|
||
| .button { | ||
| cursor: pointer; | ||
| width: 50px; |
There was a problem hiding this comment.
should have the same size as all other icons
| ' <span class="button icon-settings"></span>' + | ||
| '</div>' + | ||
| '</div>' + | ||
| '<div class="settings-menu hidden">' + |
There was a problem hiding this comment.
I'm not sure this should be in the callinfo-section, as it is not specific to the conversation, but in general?
Maybe it's time for us to start using the settings feature in the left sidebar. However I'm not sure we should go through the trouble, when we can do this easily after switching to Vue.JS ( #1347 )
There was a problem hiding this comment.
I think it is specific to the conversation just like the 'join call' button, the settings are used directly when joining the call and affect how the call appears and sounds. Putting the settings in the left sidebar might make them less obvious (and also I force the left sidebar to be hidden), the more exposed the camera, microphone and speaker settings are the better as this affects the user experience. If when the user connects their microphone is not working or their video is not working then the camera and microphone settings should be the first thing they check.
Signed-off-by: Peter Edens <[email protected]>
Co-Authored-By: Peterede <[email protected]>
Signed-off-by: Peter Edens <[email protected]>
…reed into select_media_device
Signed-off-by: Peter Edens <[email protected]>
Signed-off-by: Peter Edens <[email protected]>
|
Closing as per #1450 (comment) |
|
I'm curious what happened to the "as well as the audio output device" portion of this...? |
The user should be able to select the microphone and video input device as well as the audio output device. This pull request is for the issue #358