Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CalendarEventsDialog): keep components in one node #14232

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix insertBefore method:
    • Each inner dialog is replaced with comments in DOM, if v-if=false
    • Now they're under a single template

To test:

  • Open calendarevents dialog, then close
  • Switch to conversation, with no moderator permissions (e.g. Changelog)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

@Antreesy
Copy link
Contributor Author

/backport to stable31

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a focus-trap issue when there is an empty view (no tabbable element) and maybe in loading?
:focus-trap="loading || upcomingEvents.length !== 0" This solves when there is an empty view

src/components/CalendarEventsDialog.vue Show resolved Hide resolved
- add padding to empty content

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/calendar-insertnodebefore branch from 869e0a9 to bd8e691 Compare January 27, 2025 17:05
@Antreesy Antreesy requested a review from DorraJaouad January 27, 2025 17:05
@Antreesy Antreesy merged commit c2a3ad0 into main Jan 28, 2025
50 checks passed
@Antreesy Antreesy deleted the fix/noid/calendar-insertnodebefore branch January 28, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants