feat(compact): follow-up #14118
Merged
feat(compact): follow-up #14118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To not lose this discussion in merged PR: Inner content has a 4px gap (if there is any unread message, counter bubble is fixed on 22px+2px margin) IMO feels like we can increase icon size by that amount (cc @nimishavijay)
|
Antreesy
approved these changes
Jan 13, 2025
|
Agreed, the bigger avatar size looks better! |
DorraJaouad
force-pushed
the
fix/11697/compact-follow-up
branch
from
83f9b7b to
7a2e965
Compare
… through existing props Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
…conversation Signed-off-by: Dorra Jaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/11697/compact-follow-up
branch
from
7a2e965 to
09e62e1
Compare
Antreesy
approved these changes
Jan 14, 2025
| --list-item-height: calc(var(--clickable-area-small, 24px) + 4px) !important; | ||
| } | ||
|
|
||
| :deep(.list-item--compact .button-vue--size-normal) { |
There was a problem hiding this comment.
Maybe also remove box-shadow from the button?
There was a problem hiding this comment.
I think it's problematic even in normal view?
There was a problem hiding this comment.
well, yeah.. that out of scope of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist