Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Fix compatibility with Nextcloud 30 when using https #14062

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

nickvergessen
Copy link
Member

πŸ› οΈ API Checklist

  • we can not test this as tests are done with http:// which always has the protocol
  • But this prevented Nimisha from joining our federation room:
    • c.nc.c log: Failed to send notification for share from https://s….nextcloud.com/, received status code 400
    • s.nc.c log: entry does not contains @

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • πŸ“˜ API documentation in docs/ has been updated or is not required
  • πŸ”– Capability is added or not needed

@nickvergessen nickvergessen merged commit 74fdd1b into main Jan 9, 2025
75 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/federation-signing branch January 9, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants