-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(polls): allow editing of draft polls #13883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nickvergessen wdyt of adding the validation to the setters in the Poll Entity instead of validating them beforehand? Would make sense, don't you think? |
nickvergessen
added
2. developing
feature: api 🛠️
OCS API for conversations, chats and participants
feature: polls 📊
labels
Nov 28, 2024
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
December 2, 2024 12:00
8e473b0
to
9dcf018
Compare
nickvergessen
requested changes
Dec 6, 2024
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
December 9, 2024 11:41
2aeb3ef
to
0ca00dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor things and reaching the end soon :)
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
3 times, most recently
from
January 16, 2025 17:49
4787574
to
03c2260
Compare
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
January 20, 2025 09:57
6ae152b
to
4ea0027
Compare
Signed-off-by: Anna Larch <[email protected]> # The commit message #2 will be skipped: # fixup! feat(polls): allow editing of draft polls
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
January 20, 2025 10:49
4ea0027
to
70b43f6
Compare
nickvergessen
approved these changes
Jan 23, 2025
/backport to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required