Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace IconLink variant #13801

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: replace IconLink variant #13801

merged 1 commit into from
Nov 19, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • See screenshots

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy
fix: replace Link icon with MDI
a908e57 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Nov 18, 2024
@Antreesy Antreesy requested a review from DorraJaouad November 18, 2024 09:26
@Antreesy Antreesy self-assigned this Nov 18, 2024
@Antreesy
Copy link
Contributor Author

/backport to stable30

@SystemKeeper
Copy link
Contributor

Guess we need to align in the clients as well?

miaulalala
miaulalala approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on FF, works

@nickvergessen nickvergessen merged commit 92df717 into main Nov 19, 2024
46 checks passed
@nickvergessen nickvergessen deleted the fix/noid/mdi-link-icon branch November 19, 2024 07:48
@backportbot backportbot bot mentioned this pull request Nov 19, 2024
Merged
This was referenced Nov 19, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review design feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Antreesy @SystemKeeper @miaulalala @DorraJaouad @nickvergessen