Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor regression fixes #13797

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: minor regression fixes #13797

merged 2 commits into from
Nov 18, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 17, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

@Antreesy
fix: don't show asterisk if lastMessageMap has 0
cd10d80 
- federated conversation do not have last message id, so 0 will be stored in the map

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: autocomplete federated users mentions with mentionId
3927d0b 
- for federated users mentionId contains prefix, which should be passed

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Nov 17, 2024
@Antreesy Antreesy requested a review from DorraJaouad November 17, 2024 14:08
@Antreesy Antreesy self-assigned this Nov 17, 2024
@SystemKeeper SystemKeeper mentioned this pull request Nov 17, 2024
Closed
DorraJaouad
DorraJaouad approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy merged commit 1b015af into main Nov 18, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/13778/federation-fixups branch November 18, 2024 09:20
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Notification "*" is added even though nothing happened
2 participants
@Antreesy @DorraJaouad