Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(calls): Add email to exported participant list and list everyone … #13785

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(calls): Add email to exported participant list and list everyone … #13785

merged 1 commit into from
Nov 19, 2024

Conversation

nickvergessen
Copy link
Member

…that had joined the call

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Export the email addresses of email guests now that they are no longer the user id
  • Export all users that had joined the call

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
fix(calls): Add email to exported participant list and list everyone …
610bb57 
…that had joined the call

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added 3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: meetings 📅 Covering the webinary usecase incl. Lobby feature: call 📹 Voice and video calls labels Nov 15, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Nov 15, 2024
@nickvergessen nickvergessen self-assigned this Nov 15, 2024
miaulalala
miaulalala approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Antreesy
Antreesy approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, but forgot to respond

@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen nickvergessen merged commit d2bd3e0 into main Nov 19, 2024
69 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/add-email-to-export branch November 19, 2024 07:49
@backportbot backportbot bot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: meetings 📅 Covering the webinary usecase incl. Lobby
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @miaulalala @Antreesy