Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: localURL previews #13607

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: localURL previews #13607

merged 2 commits into from
Oct 23, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix broken video preview, when user uploads
  • Use local files for voice messages, when user uploads
  • Fix store usage, when no preview is needed

⚠️ Technically, fallbackLocalUrl is not needed for upload rather than images, but if preview is available and server doesn't return it, client should fall back to mime icon anyway, so no need to duplicate it

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Voice messages --
2024-10-22_16h44_23 2024-10-22_16h42_54
Video previews --
2024-10-22_16h46_25 2024-10-22_16h47_19

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possibleSigned-off-by: Maksim Sukharev [email protected]

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Oct 22, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 22, 2024
@Antreesy Antreesy self-assigned this Oct 22, 2024
@Antreesy Antreesy force-pushed the fix/noid/local-previews branch from 1b4f259 to cc7de63 Compare October 22, 2024 15:28
DorraJaouad
DorraJaouad approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🦅

@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy
Copy link
Contributor Author

/backport to stable30.0

@Antreesy Antreesy force-pushed the fix/noid/local-previews branch from 1157426 to f191fab Compare October 23, 2024 10:36
@Antreesy Antreesy merged commit b945d57 into main Oct 23, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/local-previews branch October 23, 2024 10:42
This was referenced Oct 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad