Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectableParticipant): fix keydown.enter event #13397

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • ⛑️ Tests are included or not possible

@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy force-pushed the fix/12850/participant-enter-key branch from 7ac12fd to 8a39610 Compare September 25, 2024 18:27
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I couldn't find a better solution

@Antreesy Antreesy force-pushed the fix/12850/participant-enter-key branch from 8a39610 to 44f8a01 Compare October 1, 2024 10:47
@Antreesy Antreesy enabled auto-merge October 1, 2024 10:47
@Antreesy Antreesy merged commit 016ffdf into main Oct 1, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12850/participant-enter-key branch October 1, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants