Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): matching current user is actor in delete message #13235

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(federation): matching current user is actor in delete message #13235

merged 1 commit into from
Sep 10, 2024

Conversation

sanskar-soni-9
Copy link
Contributor

@sanskar-soni-9 sanskar-soni-9 commented Sep 8, 2024 •
edited
Loading

☑️ Resolves

Deleting message as user1 from federated server shows user1 from host server as actor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@sanskar-soni-9 sanskar-soni-9 force-pushed the fix/current-user-matching-federated-in-delete-message branch from 28285b0 to 22265c5 Compare September 8, 2024 03:46
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Sep 10, 2024
@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Sep 10, 2024
@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen
Copy link
Member

/backport to stable29

@nickvergessen nickvergessen merged commit bc22d4d into main Sep 10, 2024
68 checks passed
@nickvergessen nickvergessen deleted the fix/current-user-matching-federated-in-delete-message branch September 10, 2024 14:57
This was referenced Sep 10, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: federation 🌐 feedback-requested
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sanskar-soni-9 @nickvergessen