feat(NoteToSelf): add tasks counter #13122
Conversation
DorraJaouad
added
3. to review
feature: frontend 🖌️
| if (!this.$refs.scroller) { | ||
| return | ||
| } | ||
| const tasksDoneCount = this.$refs.scroller.querySelectorAll('.checkbox-content__icon--checked')?.length |
There was a problem hiding this comment.
Another way could be to check message store for messages (- [ ] and - [x] ?
In case there would be an opportunity to render not all messages (virtual scroller)
There was a problem hiding this comment.
Performance-wise, it is more expensive as you will loop through messages.
Accuracy-wise, not all - [ ] are considered a checklist, maybe we need to do the same check when clicking on a list item to change the state.
DorraJaouad
force-pushed
the
fix/13034/tasks-counter
branch
2 times, most recently
from
6c37e2d to
57b5519
Compare
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/13034/tasks-counter
branch
from
57b5519 to
aba6325
Compare
|
@nickvergessen shall we backport this now, or respecting the string freeze - only after the 20.0 release? |
|
Drawn apart. I'd say lets do it, but the translation string looks "wrong" anyway |
|
/backport to stable30 |
| showUpcomingEvent() { | ||
| return this.nextEvent && !this.isInCall && !this.isSidebar && !this.isMobile | ||
| && this.conversation.type === CONVERSATION.TYPE.NOTE_TO_SELF | ||
| }, |
There was a problem hiding this comment.
Seems to be unrelated and breaking upcoming events @DorraJaouad
There was a problem hiding this comment.
Or supposed to be
!==
Still not related to task counting though 👀
There was a problem hiding this comment.
Sorry, it should be !== indeed
There was a problem hiding this comment.
Or supposed to be
!==Still not related to task counting though 👀
Also true, but as I was adding the counter and touching that space in TopBar, I thought it could be slipped in this PR.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist