[stable30] Fix using signaling session ID instead of Nextcloud session ID #12983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
3. to review
bug
feature: frontend 🖌️
CallParticipantModels provide the signaling session ID and the Nextcloud session ID. When the internal signaling server is used both IDs are the same, but not with the external signaling server. The session ID in the participant and peer data provided by the Nextcloud server is the Nextcloud session ID, so no participant or peer data was found in the CallView components when the external signaling server was used, as the data was looked for using the signaling session ID. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
"guestName" in "LocalVideo" is unused since "NcAvatar" was replaced by "AvatarWrapper" in 973a735. Signed-off-by: Daniel Calviño Sánchez <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
backport/12961/stable30
branch
from
6819258 to
9faaed2
Compare
Antreesy
approved these changes
Aug 15, 2024
|
Rebased, resolved, tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12961
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.