Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate NcModal to NcDialog #12970

Merged
merged 5 commits into from
Aug 15, 2024
Merged

fix: migrate NcModal to NcDialog #12970

merged 5 commits into from
Aug 15, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image
image image

🚧 Tasks

  • TODO:
  • migrate rest to NcDialog

🏁 Checklist

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 14, 2024
@Antreesy Antreesy requested review from ShGKme and DorraJaouad August 14, 2024 18:07
@Antreesy Antreesy self-assigned this Aug 14, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Aug 14, 2024

Didn't test, but looks fine

@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy Antreesy merged commit 16f9892 into main Aug 15, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12918/nc-dialog branch August 15, 2024 08:34
@backportbot backportbot bot mentioned this pull request Aug 15, 2024
Merged
@Antreesy Antreesy mentioned this pull request Aug 15, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad