[stable29] perf(sharing): Use getFirstNodeById() which is more performant #12554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
feature: api 🛠️
|
/backport to main |
icewind1991
reviewed
Jun 21, 2024
| $pathSegments = explode('/', $fullPath, 4); | ||
| $name = $node->getName(); | ||
| $size = $node->getSize(); | ||
| $path = $pathSegments[3] ?? $name; |
There was a problem hiding this comment.
$userFolder->getRelativePath($fullPath) is the "correct" way to do this.
icewind1991
approved these changes
Jun 21, 2024
As we don't care which node we get for rendering the message Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
perf/noid/get-first-node-by-id
branch
from
458203d to
cd6a472
Compare
This was referenced Jul 11, 2024
nickvergessen
changed the title
89 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we don't care which node we get for rendering the message
As suggested by icewind
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required