Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: audit JS dependencies #12522

Merged
merged 1 commit into from
Jun 14, 2024
Merged

chore: audit JS dependencies #12522

merged 1 commit into from
Jun 14, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

Audit JS dependencies

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added 3. to review feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file labels Jun 14, 2024
@Antreesy Antreesy added this to the 🧡 Next Patch (28) milestone Jun 14, 2024
@Antreesy Antreesy requested a review from DorraJaouad June 14, 2024 09:51
@Antreesy Antreesy self-assigned this Jun 14, 2024
@Antreesy
Copy link
Contributor Author

Audit bumps @nextcloud/capabilities to 1.2.0, which has "npm": "^10.0.0" against stable28 "npm": "^9.0.0, so I'm not so sure that we could do that

@DorraJaouad
Copy link
Contributor

I think it's fine? there are also a couple of deps that have "npm": "^10.0.0" and everything looks okay :p.
Or we can just bump npm too ?

@Antreesy
Copy link
Contributor Author

When doing dependency resolution, make sure that all the packages being installed will work with the running version of node.

Would be better to match the server. But I see in package-lock.json, that some other nextcloud libraries are already bumped to npm:^10 version, so one more wouldn't do more harm

@ShGKme
Copy link
Contributor

ShGKme commented Jun 14, 2024

which has "npm": "^10.0.0" against stable28 "npm": "^9.0.0, so I'm not so sure that we could do that

We have too strict engines requirements which does not reflect actual requirement. We don't use anything from new npm versions, so it should be fine.

@Antreesy Antreesy marked this pull request as ready for review June 14, 2024 12:52
@Antreesy Antreesy merged commit 0f06189 into stable28 Jun 14, 2024
45 checks passed
@Antreesy Antreesy deleted the chore/deps/stable28 branch June 14, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants