Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check failing sharing test #12504

Closed
wants to merge 2 commits into from
Closed

Conversation

SystemKeeper
Copy link
Contributor

@SystemKeeper SystemKeeper commented Jun 12, 2024

4a77fe3530d3213a2700b8ecdc1ccf3b4195b41a is the first bad commit
commit 4a77fe3530d3213a2700b8ecdc1ccf3b4195b41a
Author: skjnldsv <[email protected]>
Date:   Thu Jun 6 18:55:33 2024 +0200

    fix(dav): also return shared-with-me shares data
    
    Signed-off-by: skjnldsv <[email protected]>

 apps/dav/lib/Connector/Sabre/SharesPlugin.php      | 75 +++++++++++++---------
 apps/dav/lib/Server.php                            |  6 +-
 .../unit/Connector/Sabre/SharesPluginTest.php      | 22 ++++++-
 lib/private/Share20/Manager.php                    |  2 +-
 4 files changed, 69 insertions(+), 36 deletions(-)

After bisect, it seems that this is due to recent server changes. Seen while working with @skalidindi53 on #12496. Tried to narrow the failing ones down here.

Do talk tests need adjustments or is it a bug in the server PR?

@skjnldsv @nickvergessen

@SystemKeeper
Copy link
Contributor Author

Link to the PR nextcloud/server#45698

@nickvergessen
Copy link
Member

Seems to be an intended change. Will simply adjust the test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants